Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): Enhanced Transaction Submission Status Panels #25470

Merged
merged 1 commit into from
Sep 16, 2024
Merged

feat(wallet): Enhanced Transaction Submission Status Panels #25470

merged 1 commit into from
Sep 16, 2024

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Sep 6, 2024 •
edited
Loading

Description

Introduces new and enhanced Transaction Submission Status panels

Resolves brave/brave-browser#40373

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screen.Recording.4.mov

Send:

image image image

Swap:

image image image

Bridge:

image image image

ERC20 Approve:

image image image

@Douglashdaniel Douglashdaniel self-assigned this Sep 6, 2024
@Douglashdaniel Douglashdaniel requested review from a team as code owners September 6, 2024 17:12
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core puLL-Merge labels Sep 6, 2024
mkarolin
mkarolin approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++ with a nit.

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

yrliou
yrliou approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core++

onyb
onyb approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Douglashdaniel Douglashdaniel force-pushed the feat-wallet-enhanced-transaction-submission-status-panels branch 4 times, most recently from d7c46da to 8b7d10f Compare September 16, 2024 16:09
@github-actions GitHub Actions
Copy link
Contributor

[puLL-Merge] - brave/brave-core@25470

Description

This PR introduces significant changes to the Brave Wallet UI, particularly in the post-confirmation flow for transactions. It updates the visual design, adds new functionality, and improves the user experience for various transaction states (submitted, signed, completed, failed, or canceled).

Changes

Changes

  1. browser/ui/webui/brave_wallet/wallet_page_ui.cc and wallet_panel_ui.cc:

    • Added a new localized string for pending transactions.

  2. components/brave_wallet/browser/brave_wallet_constants.h:

    • Added several new localized strings for various transaction states and actions.

  3. components/brave_wallet_ui/assets/svg-icons/:

    • Removed error-circle-icon.svg.

  4. components/brave_wallet_ui/components/extension/post-confirmation/:

    • Added new components: cancel_transaction, common, failed_or_canceled.
    • Updated existing components: complete, submitted_or_signed.
    • Removed old components: failed.
    • These changes reflect a significant overhaul of the post-confirmation UI.

  5. components/brave_wallet_ui/panel/container.tsx:

    • Updated the transaction status panel dimensions.

  6. components/brave_wallet_ui/stories/:

    • Updated mock data and locale strings to support the new UI components.

  7. components/resources/wallet_strings.grdp:

    • Added new string resources for the updated UI.

  8. ui/webui/resources/BUILD.gn:

    • Added new Leo icons: "send-filled.svg" and "xmark-color.svg".

These changes represent a comprehensive update to the transaction confirmation and status UI in the Brave Wallet, introducing new visual elements, more detailed status information, and improved user interactions for various transaction states.

Possible Issues

  • The removal of some existing components and strings might cause issues if they were referenced elsewhere in the codebase.
  • The new UI components might require additional testing to ensure compatibility across different devices and screen sizes.

Security Hotspots

None identified. The changes appear to be primarily UI-related and don't introduce any obvious security concerns.

@Douglashdaniel Douglashdaniel force-pushed the feat-wallet-enhanced-transaction-submission-status-panels branch from 8b7d10f to c1b4301 Compare September 16, 2024 16:40
@Douglashdaniel Douglashdaniel force-pushed the feat-wallet-enhanced-transaction-submission-status-panels branch from c1b4301 to 896d742 Compare September 16, 2024 16:51
@Douglashdaniel Douglashdaniel merged commit c398669 into master Sep 16, 2024
17 checks passed
@Douglashdaniel Douglashdaniel deleted the feat-wallet-enhanced-transaction-submission-status-panels branch September 16, 2024 19:07
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 16, 2024
@srirambv srirambv mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarolin mkarolin mkarolin approved these changes

@yrliou yrliou yrliou approved these changes

@onyb onyb onyb approved these changes

Assignees

@Douglashdaniel Douglashdaniel

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet puLL-Merge
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging this pull request may close these issues.

Build out new Transaction Status Panels
5 participants
@Douglashdaniel @brave-builds @onyb @yrliou @mkarolin